Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use a network range for [http|transport].port when installing Elasticsearch #940

Closed
dliappis opened this issue Mar 27, 2020 · 0 comments · Fixed by #995
Closed

Don't use a network range for [http|transport].port when installing Elasticsearch #940

dliappis opened this issue Mar 27, 2020 · 0 comments · Fixed by #995
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo good first issue Small, contained changes that are good for newcomers
Milestone
2.0.1

Comments

@dliappis
Copy link
Contributor

The new install subcommand uses a range for http.port and transport.tcp.port (e.g. http.port: 39200-39300) even if the port is specified with --http-port.

We should be less lenient and configure these two properties in elasticsearch.yml without ranges.
@dliappis dliappis added enhancement Improves the status quo :Config Config file format changes, new properties, ... good first issue Small, contained changes that are good for newcomers labels Mar 27, 2020
@dliappis dliappis added this to the 1.5.0 milestone Mar 27, 2020
@danielmitterdorfer danielmitterdorfer modified the milestones: 1.5.0, 1.6.0 Apr 29, 2020
@danielmitterdorfer danielmitterdorfer added :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch and removed :Config Config file format changes, new properties, ... labels Apr 29, 2020
dliappis added a commit to dliappis/rally that referenced this issue May 12, 2020
@dliappis
Don't use range for http and transport port
9152df6 
Currently we use ranges for http and tranport port. This is error prone
if there a left over cluster forcing the Rally launched ES node to
automatically pick the next free port.

Use a specify port for http and transport port.

Closes elastic#940
@dliappis dliappis mentioned this issue May 12, 2020
Merged
dliappis added a commit that referenced this issue May 12, 2020
@dliappis
Don't use range for http and transport port (#995)
2d228bd 
Currently we use ranges for http and tranport port. This is error prone
if there a left over cluster forcing the Rally launched ES node to
automatically pick the next free port.

Use a specific port for http and transport port.

Closes #940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo good first issue Small, contained changes that are good for newcomers
Projects
None yet
Milestone
2.0.1
Development

Successfully merging a pull request may close this issue.

Don't use range for http and transport port dliappis/rally
2 participants
@danielmitterdorfer @dliappis