Accept some differing units for throttling #1103
Conversation
With elastic#1100 we introduced more flexible throttling which requires that the unit in which requests are throttled and the unit in which they are reported, are aligned. This causes issues at the moment with scroll requests which are throttled in ops/s but reported in pages/s. With this commit we correct the unit mismatch for this special case in order to stay backwards-compatible with older versions of Rally. We also ensure that throttling is preserved in test mode so our integration tests can spot such issues in the future. Relates elastic#1100
danielmitterdorfer
added
bug
There was a problem hiding this comment.
LGTM.
I think we should change (in master) the corresponding scroll queries in geonames and pmc e.g. https://github.com/elastic/rally-tracks/blob/ea52c9f601f1b5fbe485941b081d2bba9e445c20/geonames/challenges/default.json#L104-L105 to have throughput specified as "20 pages/s".
I agree; what we have here is only temporary for backwards-compatibility. After we've merged this, I'll raise a corresponding issue in rally-tracks. I think we could do the change in rally-tracks after we've released 2.1.0 so there is a long enough grace period for people to upgrade. |
|
I've created cleanup issues for the affected tracks: |
|
@elasticmachine test this please |
With #1100 we introduced more flexible throttling which requires that
the unit in which requests are throttled and the unit in which they are
reported, are aligned. This causes issues at the moment with scroll
requests which are throttled in ops/s but reported in pages/s. Similarly we have
also throttled bulk requests based on ops/s sometimes but their throughput is
reported in docs/s.
With this commit we correct the unit mismatch for this special case in
order to stay backwards-compatible with older versions of Rally. We also
ensure that throttling is preserved in test mode so our integration
tests can spot such issues in the future.
Relates #1100