Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert developers have block storage dependencies installed #1254

Merged
merged 1 commit into from Apr 28, 2021

Conversation

DJRickyB
Copy link
Contributor

While reviewing #1252, we found boto3 got de-referenced for the developer's environment (in other words, when invoking make install in a clean environment). With this commit we assert with tests that the proper dependencies are in place

@DJRickyB DJRickyB added the enhancement Improves the status quo label Apr 28, 2021
@DJRickyB DJRickyB added this to the 2.2.1 milestone Apr 28, 2021
@DJRickyB DJRickyB self-assigned this Apr 28, 2021
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dliappis dliappis self-requested a review April 28, 2021 07:07
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DJRickyB DJRickyB merged commit 51a83d7 into elastic:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants