Drop support for Elasticsearch 6.x metrics store #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us dropping support, starting with the metrics store. It's not currently raising an error at startup, though.
pquentin
added
:Metrics
DJRickyB
approved these changes
Sep 28, 2021
|
Thanks for the review, will merge on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @danielmitterdorfer for preparing the ground here, it was easy to do. :) I tested that indexes created with the old templates on 7.x still work with the new code. I'm not sure how to test the 6.x -> 7.x upgrade path, though. Is it useful to test?
As usual, this can be reviewed commit by commit if you're so inclined.
Closes #653