Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support composable template without top-level template #1489

Merged
merged 4 commits into from
May 17, 2022

Conversation

cavokz
Copy link
Contributor

@cavokz cavokz commented May 16, 2022

Fixes #1487

@cavokz cavokz force-pushed the dont-silently-filter-out-templates branch from ab8177d to 7b31dec Compare May 16, 2022 15:06
@cavokz cavokz marked this pull request as ready for review May 16, 2022 16:12
@cavokz cavokz requested a review from DJRickyB May 16, 2022 16:12
@DJRickyB DJRickyB added this to the 2.5.0 milestone May 16, 2022
@DJRickyB DJRickyB added the bug Something's wrong label May 16, 2022
Copy link
Contributor

@DJRickyB DJRickyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cavokz cavokz merged commit f8cbec1 into elastic:master May 17, 2022
@cavokz cavokz deleted the dont-silently-filter-out-templates branch May 17, 2022 05:17
@pquentin pquentin changed the title Not every composable template has a top-level template Support composable template without top-level template Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Composable templates getting silently filtered
2 participants