-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support wrapped templates produced by elastic-package dump #1492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this. Please add a description to the issue (we are doing this because elastic-package dump
produces wrapped objects, I think that's fine to mention here), and some documentation to the track reference docs
Co-authored-by: Rick Boyd <boyd.richardj@gmail.com>
Co-authored-by: Rick Boyd <boyd.richardj@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM with one nit. I don't think we should work to support a leading .
in the template-path
(for the root element), but I think one is implied by the wording JSON path
in the docs/docstrings. I know this was my wording, but if you agree I think it's better documented as the JSON field inside the file content that contains the template
. That way, we support the dot-notation in the way that you've coded but there's no reason for anyone to plug a leading .
With just a docs change to this effect, I don't see a need for further review, but please feel free to re-request
Yes, I also noticed this and you're right, better save some time now that we still remember this caveat. Fixed with d9ccf60. |
@elasticmachine run tests |
@elasticmachine update branch |
This allows to use integration assets dumped by
elastic-package
as-is, which enclose an outer meta data layer otherwise rejected when sent to Elastisearch.