Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-cluster attribute check for wrapped runners #1563

Merged
merged 5 commits into from
Aug 22, 2022

Conversation

b-deam
Copy link
Member

@b-deam b-deam commented Aug 15, 2022

With this commit we fix an existing bug where the multi-cluster attribute of
wrapped runners were not checked properly.

@b-deam b-deam added bug Something's wrong enhancement Improves the status quo labels Aug 15, 2022
@b-deam b-deam requested a review from pquentin August 15, 2022 05:32
@b-deam b-deam self-assigned this Aug 15, 2022
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm wondering about the general direction here. Looking at #488 it looks like multi-cluster support was meant for custom runners that wanted to do different operations for each cluster.

Here you want to do the same operation for all clusters, which begs the following questions:

  1. What if you don't actually want to delete data streams in all clusters?
  2. This does not generalize very well: are we going to add 100 lines of code every time we want an operation to work on all clusters?

It seems to me that we can address both those concerns by adding a new operation say all-clusters that will run a given operation on all clusters. Maybe I'm over thinking it: I'd like to know what @dliappis thinks, as he added #488.

(Also, if this was split in two commits or two PRs, we could have merged the first part! It's always suspicious when a PR or commit contains the word "and".)

esrally/driver/runner.py Outdated Show resolved Hide resolved
esrally/driver/runner.py Outdated Show resolved Hide resolved
@b-deam
Copy link
Member Author

b-deam commented Aug 17, 2022

Thanks! I'm wondering about the general direction here. Looking at #488 it looks like multi-cluster support was meant for custom runners that wanted to do different operations for each cluster.

Here you want to do the same operation for all clusters, which begs the following questions:

  1. What if you don't actually want to delete data streams in all clusters?
  2. This does not generalize very well: are we going to add 100 lines of code every time we want an operation to work an all clusters?

It seems to me that we can address both those concerns by adding a new operation say all-clusters that will run a given operation on all clusters. Maybe I'm over thinking it: I'd like to know what @dliappis thinks, as he added #488.

I agree with these comments, and therefore reverted the DeleteDataStream changes in bd11ad3 and updated #1562 with more details on more general approach to handling multi-cluster support for runners in the future. For now (to unblock me) I'll add the required logic to the custom FollowIndex runner merged via elastic/rally-tracks#293.

(Also, if this was split in two commits or two PRs, we could have merged the first part! It's always suspicious when a PR or commit contains the word "and".)

Agreed and apologies, I kept the 'bug' fix in 287fbc0. I've renamed the PR title to match.

@b-deam b-deam changed the title Make delete datastreams runner multi-cluster aware, and fix multi-cluster attribute check for wrapped runners Fix multi-cluster attribute check for wrapped runners Aug 17, 2022
@b-deam b-deam requested a review from pquentin August 17, 2022 06:16
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. I left two small comments, feel free to merge after addressing them.

esrally/driver/runner.py Show resolved Hide resolved
esrally/driver/runner.py Outdated Show resolved Hide resolved
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@b-deam b-deam merged commit e093296 into elastic:master Aug 22, 2022
@pquentin pquentin added this to the 2.7.0 milestone Nov 2, 2022
@pquentin pquentin removed the enhancement Improves the status quo label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants