Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make async context manager synchronous #1725

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Make async context manager synchronous #1725

merged 1 commit into from
Jun 7, 2023

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jun 5, 2023

It did not call any async functions, so this was only confusing analysis.

@pquentin
Make async context manager synchronous
0d40e72 
It did not call any async functions, so this was only confusing
analysis.
@pquentin pquentin added :internal Changes for internal, undocumented features: e.g. experimental, release scripts tech debt labels Jun 5, 2023
@pquentin pquentin added this to the 2.8.0 milestone Jun 5, 2023
@pquentin pquentin self-assigned this Jun 5, 2023
danielmitterdorfer
danielmitterdorfer approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification. LGTM

gbanasiak
gbanasiak approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@pquentin pquentin merged commit 7d182ad into elastic:master Jun 7, 2023
14 checks passed
@pquentin pquentin deleted the request-context-manager branch June 7, 2023 10:34
@gbanasiak gbanasiak added :misc Changes that don't affect users directly: linter fixes, test improvements, etc. and removed :internal Changes for internal, undocumented features: e.g. experimental, release scripts labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

@gbanasiak gbanasiak gbanasiak approved these changes

Assignees

@pquentin pquentin

Labels
:misc Changes that don't affect users directly: linter fixes, test improvements, etc. tech debt
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pquentin @danielmitterdorfer @gbanasiak