Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch actions and the new "shouldClearFilters" option #391

Merged
merged 21 commits into from
Sep 26, 2019

Commits on Sep 18, 2019

  1. Combined actions

    JasonStoltz committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    6f9ede1 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. Got all tests passing

    JasonStoltz committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    2374358 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. Use fake timers globally

    JasonStoltz committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    54ef4ae View commit details
    Browse the repository at this point in the history
  2. Reconciling behavior of setSearchTerm.

    Debouncing a setSearchTerm request causes strange behavior, because
    it ends up making the original API request after the subsequent
    actions. This has some odd side effects, like clearing out the filters
    that were just set.
    
    In order to work around this short term, I've added a "clearFilters"
    flag which can be added to the setSearchTerm action.
    JasonStoltz committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    0ea29a1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    253526e View commit details
    Browse the repository at this point in the history
  4. Added clearFilters option to SearchBox

    Added the clearFilter option to the SearchBox, and updated
    documentation.
    JasonStoltz committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    1f7e25c View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. Configuration menu
    Copy the full SHA
    126a3e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2019

  1. Configuration menu
    Copy the full SHA
    40279e9 View commit details
    Browse the repository at this point in the history
  2. Fixed nits

    JasonStoltz committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    93890ee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f1c88fc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5315708 View commit details
    Browse the repository at this point in the history
  5. Removed an extra coment

    JasonStoltz committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    aa0b65e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    36b8986 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    53d2c3b View commit details
    Browse the repository at this point in the history
  8. Lines. Saved.

    JasonStoltz committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    2ddb184 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    468ad88 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a2771e0 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    343994f View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2019

  1. Configuration menu
    Copy the full SHA
    b0c81b8 View commit details
    Browse the repository at this point in the history
  2. Updated setSearchTerm tests

    I updated these tests because they were testing the wrong thing.
    
    There are two side effects that occur as a result of setSearchTerm:
    _udpateSearchResults
    _makeSearchRequest
    
    _udpateSearchResults is what we are debouncing, so we want to verify
    whether that has run or not. Testing whether or not an API request
    has been make is not a good way to test this, since _makeSearchRequest
    is now always debounced.
    
    In other words, we could call _udpateSearchResults 3 times in a row
    and it will execute 3 times, but ultimately only one api call will be
    made.
    JasonStoltz committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    159f8c1 View commit details
    Browse the repository at this point in the history
  3. Finishing touches

    JasonStoltz committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    e916e87 View commit details
    Browse the repository at this point in the history