-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch actions and the new "shouldClearFilters" option #391
Merged
Commits on Sep 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6f9ede1 - Browse repository at this point
Copy the full SHA 6f9ede1View commit details
Commits on Sep 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2374358 - Browse repository at this point
Copy the full SHA 2374358View commit details
Commits on Sep 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 54ef4ae - Browse repository at this point
Copy the full SHA 54ef4aeView commit details -
Reconciling behavior of setSearchTerm.
Debouncing a setSearchTerm request causes strange behavior, because it ends up making the original API request after the subsequent actions. This has some odd side effects, like clearing out the filters that were just set. In order to work around this short term, I've added a "clearFilters" flag which can be added to the setSearchTerm action.
Configuration menu - View commit details
-
Copy full SHA for 0ea29a1 - Browse repository at this point
Copy the full SHA 0ea29a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 253526e - Browse repository at this point
Copy the full SHA 253526eView commit details -
Added clearFilters option to SearchBox
Added the clearFilter option to the SearchBox, and updated documentation.
Configuration menu - View commit details
-
Copy full SHA for 1f7e25c - Browse repository at this point
Copy the full SHA 1f7e25cView commit details
Commits on Sep 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 126a3e6 - Browse repository at this point
Copy the full SHA 126a3e6View commit details
Commits on Sep 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 40279e9 - Browse repository at this point
Copy the full SHA 40279e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93890ee - Browse repository at this point
Copy the full SHA 93890eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1c88fc - Browse repository at this point
Copy the full SHA f1c88fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5315708 - Browse repository at this point
Copy the full SHA 5315708View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa0b65e - Browse repository at this point
Copy the full SHA aa0b65eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b8986 - Browse repository at this point
Copy the full SHA 36b8986View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53d2c3b - Browse repository at this point
Copy the full SHA 53d2c3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ddb184 - Browse repository at this point
Copy the full SHA 2ddb184View commit details -
Configuration menu - View commit details
-
Copy full SHA for 468ad88 - Browse repository at this point
Copy the full SHA 468ad88View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2771e0 - Browse repository at this point
Copy the full SHA a2771e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 343994f - Browse repository at this point
Copy the full SHA 343994fView commit details
Commits on Sep 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b0c81b8 - Browse repository at this point
Copy the full SHA b0c81b8View commit details -
I updated these tests because they were testing the wrong thing. There are two side effects that occur as a result of setSearchTerm: _udpateSearchResults _makeSearchRequest _udpateSearchResults is what we are debouncing, so we want to verify whether that has run or not. Testing whether or not an API request has been make is not a good way to test this, since _makeSearchRequest is now always debounced. In other words, we could call _udpateSearchResults 3 times in a row and it will execute 3 times, but ultimately only one api call will be made.
Configuration menu - View commit details
-
Copy full SHA for 159f8c1 - Browse repository at this point
Copy the full SHA 159f8c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e916e87 - Browse repository at this point
Copy the full SHA e916e87View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.