fix the error while passing any data except string for normalization #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atiqueahmedziad
commented
Oct 4, 2022
| .toLowerCase() | ||
| .includes(accentFold(searchTerm).toLowerCase()) | ||
| typeof option.value === "string" | ||
| ? accentFold(option.value) |
There was a problem hiding this comment.
Found that option.value is not always string. Especially, when using a <Facet isFilterable={true} /> on a field like date_established, it becomes an object.
atiqueahmedziad
force-pushed
the
fix-normalize
branch
2 times, most recently
from
093eaec
to
0e0c448
Compare
atiqueahmedziad
force-pushed
the
fix-normalize
branch
from
0e0c448
to
75f178d
Compare
|
@JasonStoltz @joemcelroy review? |
|
thanks for the PR @atiqueahmedziad! Will review later on today. |
joemcelroy
approved these changes
Oct 10, 2022
|
this was released under v1.18.1 🎉 |
joemcelroy
added a commit
to joemcelroy/search-ui
that referenced
this pull request
Jan 10, 2023
…lastic#868) Co-authored-by: Joseph McElroy <joseph.mcelroy@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using a
<Facet isFilterable={true} />on a field mapped toNUMBER, we get the following error:Uncaught TypeError: str.normalize is not a functionList of changes
accentFoldfunction, it should return empty string.Associated Github Issues
Fixes #833