Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engines Connector #919

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Engines Connector #919

merged 4 commits into from
Jan 27, 2023

Conversation

joemcelroy
Copy link
Member

This is a fork of the Elasticsearch connector with some key differences:

  • Overrides the default Query Processor for Searchkit to use a single combined_fields query.
  • The connector configuration is apiKey, engineName and host. All three are needed. We do not allow to add custom headers.
  • Changed the client meta headers to engine-connector

Updated the tests.

@joemcelroy joemcelroy requested a review from a team as a code owner January 19, 2023 10:58
@joemcelroy
Copy link
Member Author

@sloanelybutsurely i've also applied the changes to elasticsearch-connector too. Thank you for reviewing!

@joemcelroy joemcelroy enabled auto-merge (squash) January 19, 2023 16:53
@joemcelroy joemcelroy merged commit a3f818a into elastic:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloanelybutsurely sloanelybutsurely sloanelybutsurely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joemcelroy @sloanelybutsurely