fix: Issue 996 - falsy values in search results #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any field which evaluates to false is returned as an empty object.
This change fixes this to return the expected { raw: field value } construct.
joemcelroy
approved these changes
Oct 6, 2023
|
thanks! Will try get it released soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the elasticsearch connector to fix mishandled falsy values
Any field which evaluates to false is returned as an empty object. This change fixes this to return the expected { raw: field value } construct.
List of changes
Changes the mapping of fields to check for existence rather than truth.
Associated Github Issues
#996