Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic branding #2

Merged
merged 17 commits into from
Aug 8, 2019
Merged

Elastic branding #2

merged 17 commits into from
Aug 8, 2019

Conversation

afoucret
Copy link
Contributor

@afoucret afoucret commented Aug 8, 2019

Highlights:

  • Licensing update (f757727)
  • Remove Swiftype reference in the code & update package name (d3cd773)
  • Readme:
    • Removed most Swiftype reference (expect doc and account
    • Better formatting of code samples
  • setup.py improvemed and add a requirements.txt files (more consistent with the App Search client)
  • tox debug (allow to run current unit test)
  • client header consistent with the completeness template
  • bump a major version in the code (2.0.0)

Change that require some attention:

Update the way we instantiate the client

To be more consistent across Python client implementations the Client object is now exposed by the module.

Old way to instantiate the client:

from swiftype import swiftype
client = swiftype.Client(api_key='YOUR_API_KEY') 

New way to instantiate the client:

from elastic_site_search import Client
client = Client(api_key='YOUR_API_KEY')

Copy link

@yakhinvadim yakhinvadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never worked with python before, so I could miss something, but everything looks ok for me, I have only a couple of comments

elastic_site_search/client.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@yakhinvadim yakhinvadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afoucret afoucret merged commit 4ae31ab into elastic:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants