Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adding stack_monitoring_agent role #127

Merged
merged 2 commits into from
Oct 25, 2018

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 10, 2018

@ycombinator
Copy link
Contributor

This LGTM but lets wait to merge this until after elastic/elasticsearch#34369 has been merged. Same dependency would apply to the backport PR as well.

@ycombinator
Copy link
Contributor

Hey @lcawl, elastic/elasticsearch#34369 still hasn't been merged but there are changes to the original proposal in that PR. Here is the new proposal for 2 built-in roles and 1 built-in user: elastic/elasticsearch#34369 (comment). Please let me know if you have any questions or need clarifications. Thanks.

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lcawl lcawl merged commit 8a7063a into elastic:master Oct 25, 2018
@lcawl lcawl deleted the lcawley-agent-role branch October 25, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants