Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds siem_cloudtrail module #1270

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Conversation

@lcawl lcawl requested a review from benskelker July 13, 2020 23:59
@lcawl lcawl marked this pull request as ready for review July 13, 2020 23:59
@lcawl lcawl requested a review from blaklaybul July 13, 2020 23:59
Copy link

@blaklaybul blaklaybul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have a lot of jobs in SIEM, I think the SIEM jobs page could benefit from having the jobs listed by module, then alphabetically within each module.

This would create six subsections in the page, one for each module:

  • SIEM Auditbeat
  • SIEM Auditbeat Authentication
  • SIEM Cloudtrail
  • SIEM Packetbeat
  • SIEM Winlogbeat
  • SIEM Winlogbeat Authentication

This structure could also be carried over to the main OOTB modules list along wit the sidebar nav.

@lcawl
Copy link
Contributor Author

lcawl commented Jul 14, 2020

Since we have a lot of jobs in SIEM, I think the SIEM jobs page could benefit from having the jobs listed by module, then alphabetically within each module...

I've drafted that change in #1275. The open question will be whether that grouping is still useful when this content is re-used in the Security Solution's docs. Hopefully yes!

@benskelker
Copy link
Contributor

I've drafted that change in #1275. The open question will be whether that grouping is still useful when this content is re-used in the Security Solution's docs. Hopefully yes!

Yep - It'll help in the Security docs as well. Thank you.

@benskelker
Copy link
Contributor

Adding @randomuserid to review the text of the new job descriptions.

@lcawl
Copy link
Contributor Author

lcawl commented Jul 15, 2020

Thanks @benskelker and @blaklaybul, this PR now groups the Cloudtrail module into a separate section.

@lcawl lcawl merged commit 99e1fbf into elastic:master Jul 21, 2020
@lcawl lcawl deleted the ml-cloudtrail branch July 21, 2020 21:43
@lcawl lcawl added the v7.10.0 label Jul 21, 2020
lcawl added a commit to lcawl/stack-docs that referenced this pull request Jul 21, 2020
lcawl added a commit to lcawl/stack-docs that referenced this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants