Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Uncomment include statements for 8.0 ES breaking changes #1879

Merged
merged 1 commit into from
Nov 15, 2021
Merged

[DOCS] Uncomment include statements for 8.0 ES breaking changes #1879

merged 1 commit into from
Nov 15, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig marked this pull request as ready for review November 15, 2021 23:05
@jrodewig jrodewig merged commit 42436e4 into elastic:8.0 Nov 15, 2021
@jrodewig jrodewig deleted the docs__uncomment-8.0-es-breaking-changes branch November 15, 2021 23:05
@kilfoyle
Copy link
Contributor

kilfoyle commented Jan 4, 2022

Hi @jrodewig!

I'd like to backport some changes I made via #1876 (which restructures the stack upgrade docs to include instructions for doing upgrades on Cloud) into the 8.0 branch. However, when I run a local docs build on the 8.0 branch it fails with several include file not found errors in breaking.asciidoc, basically the lines introduced through this PR.

Would you happen to know if those errors are expected, in which case I guess it's okay for me to ignore them and backport my changes from #1876 into the 8.0 branch?

@jrodewig
Copy link
Contributor Author

jrodewig commented Jan 4, 2022

I'd like to backport some changes I made via #1876 (which restructures the stack upgrade docs to include instructions for doing upgrades on Cloud) into the 8.0 branch. However, when I run a local docs build on the 8.0 branch it fails with several include file not found errors in breaking.asciidoc, basically the lines introduced through this PR.

Would you happen to know if those errors are expected, in which case I guess it's okay for me to ignore them and backport my changes from #1876 into the 8.0 branch?

Hi @kilfoyle!

If this is happening on a local docs built, it may just be that your local elasticsearch repo is outdated or out of sync. I took a look at your PR and didn't see any conflicts so you can likely ignore those errors.

If you somehow end up hitting errors or other issues after you backport, feel free to ping me or otherwise reach out!

@kilfoyle
Copy link
Contributor

kilfoyle commented Jan 4, 2022

Ah, of course! Can you tell that it's my first day back at work? :-)
Thanks @jrodewig. Refreshing the elasticsearch repo fixed things perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants