Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add OS/architecture classifier to distributions #194

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 31, 2019

Related to elastic/elasticsearch#37881

This PR updates the installation package names in the stack-docs repo. For example, it adds a new Linux section to https://www.elastic.co/guide/en/elastic-stack-get-started/master/get-started-elastic-stack.html#install-elasticsearch

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I am only eyeballing the package names since they aren't available yet.

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but one small thing to correct

----------------------------------------------------------------------
curl -L -O https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-{elasticsearch_version}-linux-x86_64.tar.gz
tar -xzvf elasticsearch-{elasticsearch_version}-linux-x86_64.tar.gz
cd elasticsearch-{elasticsearch_version}-linux-x86_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extracted directory name hasn't changed, so this should still be elasticsearch-{elasticsearch_version}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjernst I implemented those changes

@@ -138,7 +159,7 @@ contains the extracted files, for example:
+
["source","sh",subs="attributes,callouts"]
----------------------------------------------------------------------
cd C:\Program Files\elasticsearch-{elasticsearch_version}
cd C:\Program Files\elasticsearch-{elasticsearch_version}-windows-x86_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, the extracted directory isn't changing

cd elasticsearch-{elasticsearch_version}
curl -L -O https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-{elasticsearch_version}-darwin-x86_64.tar.gz
tar -xzvf elasticsearch-{elasticsearch_version}-darwin-x86_64.tar.gz
cd elasticsearch-{elasticsearch_version}-darwin-x86_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here too

@lcawl lcawl merged commit 2f8c24b into elastic:master Feb 1, 2019
@lcawl lcawl deleted the installation-package branch February 1, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants