Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS failures not represented correctly #246

Closed
paulb-elastic opened this issue Mar 25, 2021 · 1 comment · Fixed by #251
Closed

DNS failures not represented correctly #246

paulb-elastic opened this issue Mar 25, 2021 · 1 comment · Fixed by #251
Assignees
Labels
bug Something isn't working v7.13.0

Comments

@paulb-elastic
Copy link
Contributor

There was a suggestion that this may have been fixed, however we still don’t appear to correctly represent DNS failures in the waterfall chart.

There are two different cases of where the failure can occur, and each behaves slightly differently:

  • Where the root request fails (e.g. await page.goto("http://www.thisisaninvaliddomain.com")), this shows nothing in the waterfall chart
    image
  • Where a non root network request results in a DNS failure, in which case we show a row/entry on the waterfall chart, but don’t show any DNS timing data for it (i.e. how long it took for the DNS lookup to take place, and fail)
    image
@vigneshshanmugam
Copy link
Member

@paulb-elastic Can you share the snippets that you used for testing both scenarios?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v7.13.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants