Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle aborted/inflight network requests #251

Merged

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Apr 6, 2021

When the request is queued and the request got aborted due to browser being explicited closed or the connection cannot be established - The timing data point would look like this explaining that the given request is stalled / blocked for the whole time frame.

{
  blocked: 2.885,
  queueing: -1,
  proxy: -1,
  dns: -1,
  ssl: -1,
  connect: -1,
  send: -1,
  wait: -1,
  receive: -1,
  total: 2.885
}

Matching chrome devtools behaviour
Screen Shot 2021-04-06 at 16 58 23

@apmmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #251 opened

  • Start Time: 2021-04-06T23:58:56.581+0000

  • Duration: 18 min 53 sec

  • Commit: a230fa9

Test stats 🧪

Test Results
Failed 0
Passed 77
Skipped 0
Total 77

Trends 🧪

Image of Build Times

Image of Tests

@vigneshshanmugam vigneshshanmugam merged commit 7384dc9 into elastic:master Apr 7, 2021
@vigneshshanmugam vigneshshanmugam deleted the handle-aborted-reqs branch April 7, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS failures not represented correctly
2 participants