Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use context isolation for inidividual journeys #274

Merged
merged 1 commit into from May 13, 2021

Conversation

vigneshshanmugam
Copy link
Member

  • This PR improves the test execution time when there are multiple journeys involved while running the test suites. Previously we relied on spawning browser instance for every journey execution which is not required as context already provides enough isolation and each context is fresh (does not share any state or cache) used for each journey runs

  • This removes the time that is required for spawning browser for each run which is in order of ~100ms.

Results (Approx)

  1. For todos directory with 4 journeys
Before - 3600ms
After - 2400ms
  1. Custom with increased number of journeys to showcase the impact.
// 20 journeys
Before - 11200ms
After - 5800ms

// 50 journeys
Before - 28700ms
After - 14800ms

@vigneshshanmugam vigneshshanmugam added the enhancement New feature or request label May 11, 2021
@apmmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #274 opened

  • Start Time: 2021-05-11T20:52:04.470+0000

  • Duration: 15 min 56 sec

  • Commit: e3a3db5

Test stats 🧪

Test Results
Failed 0
Passed 87
Skipped 0
Total 87

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc andrewvc merged commit f50e65e into elastic:master May 13, 2021
@vigneshshanmugam vigneshshanmugam deleted the improve-test-time branch May 13, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants