feat: improve project scaffolding experience #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshshanmugam
force-pushed
the
improve-init
branch
from
7ab9cfd
to
824a920
Compare
emilioalvap
reviewed
Apr 1, 2024
emilioalvap
reviewed
Apr 1, 2024
justinkambic
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Left one comment on the UX. It'd be nice to improve as part of this patch, but if it can't be accomplished quickly I am ok if we don't block this, and I can update the issue to reflect the need for a future patch.
Functionality LGTM and I tested this pushing to a cloud project via cloud ID and URL methods, both worked well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initcommand takes args to skip dialogue steps #907