Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve project scaffolding experience #911

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Mar 29, 2024

src/generator/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment on the UX. It'd be nice to improve as part of this patch, but if it can't be accomplished quickly I am ok if we don't block this, and I can update the issue to reflect the need for a future patch.

Functionality LGTM and I tested this pushing to a cloud project via cloud ID and URL methods, both worked well.

@vigneshshanmugam vigneshshanmugam merged commit 7c75279 into elastic:main Apr 2, 2024
7 checks passed
@vigneshshanmugam vigneshshanmugam deleted the improve-init branch April 2, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide API key during CLI init dialogue and optionally export to env, combine Cloud ID and Kibana URL prompt
3 participants