Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the node version restriction #343

Merged
merged 1 commit into from Jul 8, 2021
Merged

fix: remove the node version restriction #343

merged 1 commit into from Jul 8, 2021

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Jul 7, 2021 •
edited

  • fix errors that will be thrown when using different version of node on the local environment.

From Kibana

info [bazel] error @elastic/synthetics@1.0.0-beta.8: The engine "node" is incompatible with this module. Expected version "12.18.4". Got "14.17.2"
  • CI still runs with the version of 12.18.4 as per .nvmrc file.

@apmmachine
Copy link
Collaborator

apmmachine commented Jul 7, 2021 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-08T00:18:49.887+0000

  • Duration: 15 min 39 sec

  • Commit: d7635e6

Test stats 🧪

Test Results
Failed 0
Passed 119
Skipped 0
Total 119

Trends 🧪

Image of Build Times

Image of Tests

shahzad31
shahzad31 approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@vigneshshanmugam vigneshshanmugam merged commit 0b7b253 into elastic:master Jul 8, 2021
@vigneshshanmugam vigneshshanmugam deleted the loosen-engine branch July 8, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vigneshshanmugam @apmmachine @shahzad31