Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite screenshots blocks timestamp with creation time #411

Closed
vigneshshanmugam opened this issue Nov 10, 2021 · 4 comments · Fixed by #413
Closed

rewrite screenshots blocks timestamp with creation time #411

vigneshshanmugam opened this issue Nov 10, 2021 · 4 comments · Fixed by #413
Labels
bug Something isn't working

Comments

@vigneshshanmugam
Copy link
Member

  • Currently screenshot block timestamp is based on screenshot blob construction time instead of when the screenshot was taken. As a result, the screenshot timestamp would be greater than the journey/end timestamp which is not true.

Wrong order

-- step/end timestamp
-- journey/end timestamp

--- screenshot/block timestamp
--- screenshot/block timestamp

-- end timestamp

Correct order

-- screenshot/block timestamp
-- screenshot/block timestamp

-- step/end timestamp
-- journey/end timestamp
-- end timestamp
@paulb-elastic
Copy link
Contributor

Assuming the screenshot construction takes some amount of time, won'y this cause the step to appear to take longer because we’re counting the compute time to generate the screenshot?

@vigneshshanmugam
Copy link
Member Author

@paulb-elastic Screenshot block construction logic is unchanged and it happens only after all the steps have been completed, so it wont get accounted in to the step/end time nor the journey/end time which we fixed recently as customers are seeing increased journey duration.

The idea here is to use the timestamp of when the screenshot taken vs when the screenshot was processed (converting to blocks). We are moving to former approach.

@paulb-elastic
Copy link
Contributor

Thanks @vigneshshanmugam

@dominiqueclarke
Copy link
Contributor

7.16 Uptime UI looks good with good with beta.17. Timestamps for step/screenshot_ref are lower than timestamps for heartbeat/sumamry docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants