Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure timestamps of events are inorder #413

Merged
merged 2 commits into from
Nov 11, 2021
Merged

fix: ensure timestamps of events are inorder #413

merged 2 commits into from
Nov 11, 2021

Conversation

vigneshshanmugam
Copy link
Member

@apmmachine
Copy link
Collaborator

apmmachine commented Nov 10, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-11T16:25:06.092+0000

  • Duration: 14 min 24 sec

  • Commit: 60e33bf

Test stats 🧪

Test Results
Failed 0
Passed 143
Skipped 0
Total 143

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

dominiqueclarke
dominiqueclarke approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/reporters/json.ts
_id: block.id,
blob: block.blob,
blob_mime,
});
}
this.writeJSON({
type: 'step/screenshot_ref',
timestamp: screenshot.timestamp,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using the document timestamp in the UI. I'm assuming we should move to using this timestamp.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We rewrite it to document timestamp here -

synthetics/src/reporters/json.ts

Line 584 in 926e7d8

'@timestamp': timestamp || getTimestamp(),

@vigneshshanmugam vigneshshanmugam merged commit 9443c17 into elastic:master Nov 11, 2021
@vigneshshanmugam vigneshshanmugam deleted the screenshot-timestamps branch November 11, 2021 17:05
v1v added a commit to dominiqueclarke/synthetics that referenced this pull request Nov 22, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/360-kiban…
001fab1 
…a-fleet-heartbeat-synthetics-e2e-tests

* upstream/master:
  [jjbb] for scheduling e2e jobs (elastic#418)
  docs: release notes for beta.17 (elastic#415)
  1.0.0-beta.17
  feat: add --playwright-options (elastic#405)
  fix: ensure timestamps of events are inorder (elastic#413)
  fix: do not stash `.nvm` folder (elastic#414)
  deprecate suite-params option over params (elastic#406)
  fix: end timestamp should reflect duration (elastic#410)
  docs: release notes for 1.16.0 (elastic#403)
  1.0.0-beta.16
  fix: revert Playwright to 1.14.0 (elastic#402)
  docs: release notes for beta 15 (elastic#400)
  1.0.0-beta.15
  chore: update deps and fix lint issues (elastic#399)
  fix: handle page close during response event (elastic#398)
  chore: require node > 14 for usage (elastic#397)
  fix: fix megabytes to mbps (elastic#394)
  feat: enable trace as part of rich-events (elastic#387)
  feat: use events from PW for network data (elastic#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@andrewvc andrewvc Awaiting requested review from andrewvc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rewrite screenshots blocks timestamp with creation time
3 participants
@vigneshshanmugam @apmmachine @dominiqueclarke