Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support SYNTHETICS_API_KEY env variable for auth #588

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 6, 2022

read auth from SYNTHETICS_API_KEY if available

@shahzad31 shahzad31 changed the title do one by one push only in case of cloud locations Allow env vars usage for url and auth Sep 6, 2022
@apmmachine
Copy link
Collaborator

apmmachine commented Sep 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-09T18:24:44.535+0000

  • Duration: 13 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 185
Skipped 2
Total 187

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@shahzad31 shahzad31 changed the title Allow env vars usage for url and auth Allow env vars usage for auth Sep 7, 2022
@shahzad31 shahzad31 marked this pull request as ready for review September 7, 2022 09:35
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if we are doing this, then need to change the project generation command a bit differently.

We can remove this -

pkgJSON.scripts.push = `npx @elastic/synthetics push --auth $SYNTHETICS_API_KEY`;

src/cli.ts Outdated Show resolved Hide resolved
@vigneshshanmugam vigneshshanmugam changed the title Allow env vars usage for auth feat: support SYNTHETICS_API_KEY env variable for auth Sep 9, 2022
@vigneshshanmugam vigneshshanmugam merged commit ad5aa93 into main Sep 9, 2022
@vigneshshanmugam vigneshshanmugam deleted the use-env-vars branch September 9, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants