Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --no-headless cli option #813

Merged
merged 2 commits into from
Aug 2, 2023
Merged

feat: add --no-headless cli option #813

merged 2 commits into from
Aug 2, 2023

Conversation

shahzad31
Copy link
Contributor

add --no-headless cli option

fixes #799

vigneshshanmugam
vigneshshanmugam reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for the headless option overriding PW options when passed.

devcorpio
devcorpio approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@devcorpio devcorpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit c560bef into main Aug 2, 2023
8 checks passed
@shahzad31 shahzad31 deleted the headless branch August 2, 2023 09:15
@paulb-elastic paulb-elastic mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam left review comments

@devcorpio devcorpio devcorpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

we should support --no-headless as base option for cli runner
3 participants
@shahzad31 @vigneshshanmugam @devcorpio