Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): missing quoting the echo command #858

Merged
merged 2 commits into from
Oct 26, 2023
Merged

fix(ci): missing quoting the echo command #858

merged 2 commits into from
Oct 26, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 25, 2023

What

Fix the missing quote and enable this step to run always to help with testing this in this branch

Test

https://github.com/elastic/synthetics/actions/runs/6636911709/job/18030209681 tested this PR.

@v1v v1v requested review from vigneshshanmugam and a team October 25, 2023 06:56
.github/workflows/release.yml Outdated Show resolved Hide resolved
@@ -43,10 +43,9 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}

- name: Get version and package name
if: ${{ github.event.inputs.dry-run == 'false' }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets run this always

@v1v v1v added bug Something isn't working Team:Automation Label for the Observability productivity team labels Oct 25, 2023
@v1v v1v self-assigned this Oct 25, 2023
@v1v v1v changed the title fix(ci): missing quoting the echo fix(ci): missing quoting the echo command Oct 25, 2023
@v1v v1v merged commit 3f5b18b into main Oct 26, 2023
12 checks passed
@vigneshshanmugam vigneshshanmugam deleted the v1v-patch-1 branch October 26, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants