New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: buildkite bare minimun cli reporter #872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good mostly, just added few comments for errors and output formats.
@@ -63,7 +63,16 @@ export type { | |||
export type { default as Runner } from './core/runner'; | |||
export type { Reporter, ReporterOptions } from './reporters'; | |||
|
|||
export type { SyntheticsConfig } from './common_types'; | |||
export type { | |||
SyntheticsConfig, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: expose StartEvent
src/reporters/build_kite_cli.ts
Outdated
@@ -70,42 +62,44 @@ export default class BuildKiteCLIReporter extends BaseReporter { | |||
const { failed, succeeded, skipped } = this.metrics; | |||
const total = failed + succeeded + skipped; | |||
if (total === 0 && error) { | |||
this.write(renderError(error)); | |||
this.write(renderError(serializeError(error))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a indentation issue here. I would just do the same here by calling super.onJourneyEnd
and then add the Took duration message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
bare minimun cli reporter