Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: double monitor bundle size to 1500Kb #882

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/push/bundler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ import archiver from 'archiver';
import { commonOptions } from '../core/transform';
import { SyntheticsBundlePlugin } from './plugin';

const SIZE_LIMIT_KB = 800;
// 1500KB Max Gzipped limit for bundled code to be pushed as Kibana project monitors.
const SIZE_LIMIT_KB = 200;

function relativeToCwd(entry: string) {
return path.relative(process.cwd(), entry);
Expand Down Expand Up @@ -100,7 +101,7 @@ export class Bundler {
const sizeKb = size / 1024;
if (sizeKb > SIZE_LIMIT_KB) {
throw new Error(
`You have monitors whose size exceeds the ${SIZE_LIMIT_KB}KB limit.`
`Bundled monitor code exceeds the recommended ${SIZE_LIMIT_KB}KB limit. Please check your dependencies and try again.`
);
}
}
Expand Down