Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 429 add debug mode #430

Merged
merged 4 commits into from
Mar 16, 2022
Merged

feat: 429 add debug mode #430

merged 4 commits into from
Mar 16, 2022

Conversation

luigibk
Copy link
Contributor

@luigibk luigibk commented Jan 28, 2022

Add -debug option and related code to allow debugger-based debugging to use with a tool like delve to inspect what is happening in a provider as it is happening.

Description

A detailed explanation is available in this section of the Terraform plugin sdk documentation:
debugger-based-debugging

Related Issues

#429

Motivation and Context

It allows investigating some issues easily.

How Has This Been Tested?

Issue investigation. See linked issue #429

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@luigibk luigibk requested a review from a team as a code owner January 28, 2022 10:26
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@luigibk luigibk requested a review from a team as a code owner February 23, 2022 11:03
@tobio
Copy link
Member

tobio commented Feb 27, 2022

jenkins test this

@tobio tobio merged commit 6d64793 into elastic:master Mar 16, 2022
@luigibk luigibk deleted the add-debug-mode-429 branch March 24, 2022 11:50
tobio pushed a commit that referenced this pull request May 10, 2022
* feat: 429 add debug mode

* clean up

* Add const comment

* fix: make build gcflags issue
tobio pushed a commit that referenced this pull request May 10, 2022
* feat: 429 add debug mode

* clean up

* Add const comment

* fix: make build gcflags issue
tobio added a commit that referenced this pull request May 10, 2022
* feat: 429 add debug mode (#430)

* feat: 429 add debug mode

* clean up

* Add const comment

* fix: make build gcflags issue

* fix(deps): update module github.com/stretchr/testify to v1.7.1 (#456)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update actions/checkout action to v3 (#451)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Update CHANGELOG.md and NOTICE

* chore(deps): update endbug/add-and-commit action to v9 (#454)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update actions/setup-go action to v3 (#448)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* fix(deps): update module github.com/go-openapi/runtime to v0.23.2 (#452)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Update CHANGELOG.md and NOTICE

* chore(deps): update actions/cache action to v3 (#458)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update peterjgrainger/action-create-branch action to v2.2.0 (#461)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update hashicorp/setup-terraform action to v2 (#470)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Update CHANGELOG.md and NOTICE

* Include a note in the import docs mentioning that the credentials will not be available. (#464)

* fix(deps): update module github.com/hashicorp/terraform-plugin-sdk/v2 to v2.11.0 (#453)

* fix(deps): update module github.com/hashicorp/terraform-plugin-sdk/v2 to v2.11.0

* Move debug mode to ServeOpts

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Toby Brain <toby.brain@elastic.co>

* Update CHANGELOG.md and NOTICE

* Update CHANGELOG.md and NOTICE

* Update CHANGELOG.md and NOTICE

* Allow zero sized topology elements when autoscaling is enabled (#472)

* Allow zero sized topology elements when autoscaling is enabled

* Fix acceptance test

* fix(deps): update module github.com/hashicorp/terraform-plugin-sdk/v2 to v2.14.0 (#475)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Provide a default for the autoscaling min/max resource (#477)

* Provide a default for the autoscaling min/max resource

This fixes an issue when specifying an autoscaling min/max when there is no corresponding min/max defined in the deployment template

* PR feedback

* fix(deps): update module github.com/elastic/cloud-sdk-go to v1.9.0 (#480)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Update CHANGELOG.md and NOTICE

* Update CHANGELOG.md and NOTICE

* Update CHANGELOG.md and NOTICE

* fix(deps): update module github.com/go-openapi/runtime to v0.24.0 (#457)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Update CHANGELOG.md and NOTICE

* Update CHANGELOG.md and NOTICE

* Update CHANGELOG.md and NOTICE

* Update CHANGELOG.md and NOTICE

* fix(deps): update module github.com/hashicorp/terraform-plugin-sdk/v2 to v2.15.0 (#481)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Update CHANGELOG.md and NOTICE

* Fixes arguments for add-and-commit (#479)

* Fixes arguments for add-and-commit 

These were changed in v8. https://github.com/EndBug/add-and-commit/blob/main/CHANGELOG.md#800---2022-01-20

* Change branch property on the minor bump.

* Fetch full repo history when checking out.

make minor inspects the current git tags before bumping. Without fetching those tags, the task fails.

* Add changelog

* Download the Terraform CLI for acceptance tests

This should be temporary, the automated download is currently failing due to an unexpected content-type on the response

Co-authored-by: luigibk <41112628+luigibk@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: elasticcloudclients <elasticcloudclients@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants