[Bug] Cannot create index with number_of_replicas=0

[paivin-dn]

Describe the bug
I've tried to create an index with the parameter number_of_replicas=0, but in an elasticsearch instance, I've got an index with number_of_replicas=1.

To Reproduce
Steps to reproduce the behavior:

1. Define index in a terraform code:

resource "elasticstack_elasticsearch_index" "example" {
  name               = "example"
  number_of_shards   = 1
  number_of_replicas = 0
}

2. Run the terraform plan & terraform plan commands
3. Check index settings and make sure index.number_of_replicas = 1.

Expected behavior
The created index should have index.number_of_replicas = 0 instead of index.number_of_replicas = 0

Versions (please complete the following information):

• OS: macOS
• Terraform Version: v1.1.7
• Provider version: 0.5.0
• Elasticsearch Version: 8.3.2

[k-yomo]

The root cause would be that if raw, ok := d.GetOk(tfFieldKey); ok { will only be true when the value is not zero value and zero value can't be set at create time.
It seems that's known issue and can be fixed by migrating to new sdk(terraform-provider-framework) since they have IsNull method to check if not set, or is explicitly set to null.

terraform-provider-elasticstack/internal/utils/utils.go

Lines 148 to 163 in c5e4095

	func ExpandIndividuallyDefinedSettings(ctx context.Context, d *schema.ResourceData, settingsKeys map[string]schema.ValueType) map[string]interface{} {
	settings := make(map[string]interface{})
	for key := range settingsKeys {
	tfFieldKey := ConvertSettingsKeyToTFFieldKey(key)
	if raw, ok := d.GetOk(tfFieldKey); ok {
	switch field := raw.(type) {
	case *schema.Set:
	settings[key] = field.List()
	default:
	settings[key] = raw
	}
	tflog.Trace(ctx, fmt.Sprintf("expandIndividuallyDefinedSettings: settingsKey:%+v tfFieldKey:%+v value:%+v, %+v", key, tfFieldKey, raw, settings))
	}
	}
	return settings
	}

Workaround would be

1. create with value > 0 and update number_of_replicas to 0 after.

resource "elasticstack_elasticsearch_index" "example" {
  name               = "example"
  number_of_shards   = 1
  number_of_replicas = 1
}

2. use settings field (it's now deprecated though)

resource "elasticstack_elasticsearch_index" "example" {
  name               = "example"
  number_of_shards   = 1

  settings {
    setting {
      name  = "number_of_replicas"
      value = "0"
    }
  }
}

[paivin-dn]

The root cause would be that if raw, ok := d.GetOk(tfFieldKey); ok { will only be true when the value is not zero value and zero value can't be set at create time. It seems that's known issue and can be fixed by migrating to new sdk(terraform-provider-framework) since they have IsNull method to check if not set, or is explicitly set to null.

terraform-provider-elasticstack/internal/utils/utils.go

Lines 148 to 163 in c5e4095

	func ExpandIndividuallyDefinedSettings(ctx context.Context, d *schema.ResourceData, settingsKeys map[string]schema.ValueType) map[string]interface{} {
	settings := make(map[string]interface{})
	for key := range settingsKeys {
	tfFieldKey := ConvertSettingsKeyToTFFieldKey(key)
	if raw, ok := d.GetOk(tfFieldKey); ok {
	switch field := raw.(type) {
	case *schema.Set:
	settings[key] = field.List()
	default:
	settings[key] = raw
	}
	tflog.Trace(ctx, fmt.Sprintf("expandIndividuallyDefinedSettings: settingsKey:%+v tfFieldKey:%+v value:%+v, %+v", key, tfFieldKey, raw, settings))
	}
	}
	return settings
	}

Workaround would be

1. create with value > 0 and update number_of_replicas to 0 after.

resource "elasticstack_elasticsearch_index" "example" {
  name               = "example"
  number_of_shards   = 1
  number_of_replicas = 1
}

2. use settings field (it's now deprecated though)

resource "elasticstack_elasticsearch_index" "example" {
  name               = "example"
  number_of_shards   = 1

  settings {
    setting {
      name  = "number_of_replicas"
      value = "0"
    }
  }
}

Thank you for your reply!

[james-world]

I ran into this recently - not sure why this bug is closed since it isn't fixed?

[olfek]

I'm seeing this problem with the new version of everything

[tobio]

Requires #214