This repository has been archived by the owner on May 24, 2023. It is now read-only.
Pass config directory to JvmOptionsParser #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates: elastic/elasticsearch#51882 With the introduction of jvm.options.d directory for customizing jvm.options, the config directory path is now passed to jvm.options parser tool instead of the jvm.options path. See the elasticsearch.bat change for comparison: https://github.com/elastic/elasticsearch/pull/51882/files#diff-6c06e8a0d0742dc053b8afcbfb2b4201R76 Fixes #363
|
Thanks for looking at it @russcam ! Was on my list today, still very appreciated! |
|
Thanks for this, went to do my upgrade today and ran into this issue. |
russcam
added a commit
that referenced
this pull request
May 19, 2020
Relates: elastic/elasticsearch#51882 With the introduction of jvm.options.d directory for customizing jvm.options, the config directory path is now passed to jvm.options parser tool instead of the jvm.options path. See the elasticsearch.bat change for comparison: https://github.com/elastic/elasticsearch/pull/51882/files#diff-6c06e8a0d0742dc053b8afcbfb2b4201R76 Fixes #363 (cherry picked from commit 31f27ce)
russcam
added a commit
that referenced
this pull request
May 19, 2020
Relates: elastic/elasticsearch#51882 With the introduction of jvm.options.d directory for customizing jvm.options, the config directory path is now passed to jvm.options parser tool instead of the jvm.options path. See the elasticsearch.bat change for comparison: https://github.com/elastic/elasticsearch/pull/51882/files#diff-6c06e8a0d0742dc053b8afcbfb2b4201R76 Fixes #363 (cherry picked from commit 31f27ce)
russcam
added a commit
that referenced
this pull request
May 19, 2020
Relates: elastic/elasticsearch#51882 With the introduction of jvm.options.d directory for customizing jvm.options, the config directory path is now passed to jvm.options parser tool instead of the jvm.options path. See the elasticsearch.bat change for comparison: https://github.com/elastic/elasticsearch/pull/51882/files#diff-6c06e8a0d0742dc053b8afcbfb2b4201R76 Fixes #363 (cherry picked from commit 31f27ce)
This was referenced May 19, 2020
Closed
Closed
ghost
mentioned this pull request
This was referenced Jul 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: elastic/elasticsearch#51882
With the introduction of jvm.options.d directory for customizing
jvm.options, the config directory path is now passed to jvm.options
parser tool instead of the jvm.options path. See the elasticsearch.bat
change for comparison:
https://github.com/elastic/elasticsearch/pull/51882/files#diff-6c06e8a0d0742dc053b8afcbfb2b4201R76
Fixes #363