use strict bash #53
Merged
use strict bash #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stemming from `git config --remove-section` commands git 2.18+ (Q2 2018) will remove empty sections on its own as per https://stackoverflow.com/a/50274206/465684
andreineculau
force-pushed
the
patch-strict-bash
branch
from
8e37456
to
6246a86
Compare
andreineculau
force-pushed
the
patch-strict-bash
branch
from
6246a86
to
712e96d
Compare
|
I have historically been averse to using Bash "strict" mode due to all the unintuitive edge cases, so I was admittedly averse to this PR when I saw the subject, but I was pleasantly surprised by your changes. Very cleanly done, and I do think it's a nice improvement! Thanks for all the contributions, and for pushing my own thinking on the matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see http://redsymbol.net/articles/unofficial-bash-strict-mode/
PR on top of #52