Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MT-3568] EPCC Ref Store - Global search: Enable voice search #50

Merged
merged 6 commits into from Aug 12, 2020

Conversation

bdong8boss
Copy link
Contributor

@bdong8boss bdong8boss commented Aug 6, 2020

Description:
Add the voice search button next to the search box, when you click on the voice search, it has some animation to show it is listening for input. We use three icons for the voice search and it is added to the assets folder.

Linting:

  • No linting errors

Tests:

  • E2E tests
  • Manual tests
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@dusanradovanovic dusanradovanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments mostly regarding syntax, but generally looks ok.

src/SearchBar.scss Outdated Show resolved Hide resolved
src/SearchBar.scss Outdated Show resolved Hide resolved
src/SearchBar.scss Show resolved Hide resolved
src/SearchBar.tsx Outdated Show resolved Hide resolved
src/SearchBar.tsx Outdated Show resolved Hide resolved
src/SearchBar.tsx Outdated Show resolved Hide resolved
src/SearchBar.tsx Outdated Show resolved Hide resolved
src/SearchBar.tsx Outdated Show resolved Hide resolved
@dusanradovanovic
Copy link
Contributor

I've tried testing voice search on the Netlify instance but nothing happens? Google shows like it is recording sound for a second or two and than it just stops.

@shaunmaharaj shaunmaharaj changed the title [[MT-3568]EPCC Ref Store - Global search: Enable voice search [MT-3568] EPCC Ref Store - Global search: Enable voice search Aug 7, 2020
@bdong8boss
Copy link
Contributor Author

I've tried testing voice search on the Netlify instance but nothing happens? Google shows like it is recording sound for a second or two and than it just stops.

It works for me. Could you please do a force refresh?

src/SearchBar.scss Outdated Show resolved Hide resolved
src/SearchBar.tsx Outdated Show resolved Hide resolved
@shaunmaharaj shaunmaharaj merged commit 25f5c04 into master Aug 12, 2020
@shaunmaharaj shaunmaharaj deleted the MT-3568 branch August 12, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants