New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error with empty `ImageContainerSrcs.sizes` array #719

Merged

shaunmaharaj merged 1 commit into master from no-sizes-config

May 19, 2020

Contributor

aChanEP commented May 19, 2020 •

edited

Description:

This PR fixes the case where no sizes are defined in the ImageContainerSrcs.sizes. Picture element will now still work with just variance in types

Linting:

No linting errors

Tests:

E2E tests (npm test run with e2e)
Manual tests
Accessibility tests (no new react-axe errors in console)

Documentation:

Requires documentation updates
Requires Storybook component updates


          enable no sizes in configs

aChanEP changed the title ~~[WIP]enable no sizes in configs~~ Fix error with empty ImageContainerSrcs.sizes array

aChanEP requested a review from shaunmaharaj

May 19, 2020 20:51

shaunmaharaj approved these changes

View reviewed changes

shaunmaharaj approved these changes

View reviewed changes

shaunmaharaj merged commit 79dde85 into master

shaunmaharaj deleted the no-sizes-config branch

May 19, 2020 22:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment