Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Elasticsearch 5.0.0 #124

Closed
Sennik opened this issue Oct 28, 2016 · 34 comments
Closed

Compatibility with Elasticsearch 5.0.0 #124

Sennik opened this issue Oct 28, 2016 · 34 comments

Comments

@Sennik
Copy link

Sennik commented Oct 28, 2016

illegal_argument_exception: The parameter [fields] is no longer supported, please use [stored_fields] to retrieve stored fields or _source filtering if the field is not stored

It seems that Elastiquent is not compatible with the latest version of Elasticsearch. Or did I something wrong?

@niefufeng
Copy link

elasticsearch version 5.x 不再支持fields字段

@niefufeng
Copy link

@timgws @chuangbo

@timgws
Copy link
Member

timgws commented Nov 14, 2016

I will be installing ES 5 soon and having a bit of a play around with it to work out exactly why this is not working.

@ellisio
Copy link

ellisio commented Dec 30, 2016

Any progress on this?

@andrewmclagan
Copy link

andrewmclagan commented Jan 30, 2017

HAs there been any progress with ES 5.x.x ?

@timgws

@timgws
Copy link
Member

timgws commented Jan 30, 2017

There has been a tiny bit of progress, @andrewmclagan

@andrewmclagan
Copy link

Awesome, Seems the underlying library elasticsearch/elasticsearch needs updating to 5.x.x. I would love to give a hand, is there a branch that I can take a look at. I will be needing 5 support ASAP and I'm willing to jump straight into it tomorrow.

@timgws

@timgws
Copy link
Member

timgws commented Jan 30, 2017

Awesome. Let me commit some code later tonight so you can test tomorrow and start digging into it straight away in the morning, @andrewmclagan

@andrewmclagan
Copy link

@timgws appreciate it :-) just let me know what the branch is.

@jacob-v-dam
Copy link

When will this be released? I need this for a new version of elasticsearch.

@ppeer
Copy link

ppeer commented Mar 9, 2017

I am running elasticsearch 5.2.2 & in combination with elasticquent and the searchByQuery command returns:
illegal_argument_exception: The parameter [fields] is no longer supported, please use [stored_fields] to retrieve stored fields or _source filtering if the field is not stored

is there a solution yet or do you recommend installing an older elasticsearch version?

@andrewmclagan
Copy link

I was going to submit a PR to address this although we have migrated to our own solution. Personally I think this repo is great, although it needs a little more abstraction and separation for our needs. Apologies everyone.

Maybe at a later date we can migrate some of our work into this repo.

@ppeer
Copy link

ppeer commented Mar 10, 2017

Lacking the time to give input to this great repo, i switched back to ES 2.4 to overcome this problem. For now I hope elasticquent will try to keep up it's intermediate position between (new) laravel and elasticsearch (versions).

@timgws
Copy link
Member

timgws commented May 22, 2017

Yes, there is. I will be pushing the new version for testing soon.

I am currently working on a test suite that can be used to test the application end-to-end. This will help ease issues with updating to newer versions of Elasticsearch & compatibility with this application 👍

@andrewmclagan
Copy link

@timgws I would be interested in how you are undertaking the e2e tests!

We use a docker based build pipeline called Drone, very easy to boot up an Elasticsearch server and then tear it down again.

@timgws
Copy link
Member

timgws commented May 22, 2017

@andrewmclagan Currently, it's based on https://github.com/elastic/elasticsearch-docker, a modified Makefile with a modified elasticsearch.yaml file depending on the passed in values for version & port in the Makefile.

I am testing against Elasticsearch 5.4, 2.4 and 2.0.

My test.sh script checks if an Elasticsearch image has been built for the selected version, builds it if not, then runs all the images on different ports.

PHPUnit then runs the same test suite three times (one time for each port that Elasticsearch is running on). It reports the latest version of Elasticsearch to coveralls.

I am not yet sure how I can set up Coveralls to run the test suite automatically for all versions of Elasticsearch. This would be preferable.

Have just performed a quick Google for Drone and so far this looks like it might be the missing piece of the puzzle!

I am currently busy working on another project, so for the time being the test.sh script that I have is going to have to do. I will try and get that all checked in soon!

@andrewmclagan
Copy link

Drone is amazing...

@musab95
Copy link

musab95 commented May 25, 2017

I am running elasticsearch 5.4.0 with elasticquent in which search() is work but searchByQuery() return error:
exception 'Elasticsearch\Common\Exceptions\BadRequest400Exception' with message '{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"The parameter [fields] is no longer supported, please use [stored_fields] to retrieve stored fields or _source filtering if the field is not stored"}],"type":"illegal_argument_exception","reason":"The parameter [fields] is no longer supported, please use [stored_fields] to retrieve stored fields or _source filtering if the field is not stored"},"status":400}'

Please suggest me some solution.

@rschuil
Copy link

rschuil commented May 25, 2017

@musab95 not a solution but as a temporary workaround I added this to my model:
private function buildFieldsParameter($getSourceIfPossible, $getTimestampIfPossible) { return null; }

@musab95
Copy link

musab95 commented May 26, 2017

thanks @rschuil
its work for me

@ppeer
Copy link

ppeer commented Jun 1, 2017

unfortunately, not working for me: laravel 5.2 elasticsearch 5.3.0. Is there anything else I could try?

@ajayfroiden
Copy link

Can anyone please let me know if it now available for elasticsearch 5.4.0 or not? I could not find the clear answer.

@Its-rahulG
Copy link

hi, is there any update regarding this thread, i'm dying to include this package in my production app.

@molbi
Copy link

molbi commented Jun 30, 2017

@timgws hi, we use this package a lot, it is great, but know, we need upgrade ES to v5 and i really dont want using fork repositories, but know it is only one option. Do you know, when new patch will be? ;) thank you man.

@ajayfroiden
Copy link

@timgws and other contributors. Please respond the the queries. We do want this package to be upgraded

@PeteJStewart
Copy link

@timgws Did this get resolved?
From what I can tell, Elasticquent doesn't work with Elasticsearch 5.x?
It only seems to work with 2.x.
Is this the case? Is there a plan to resolve this, or should we all be looking at alternative systems?

@xav-akumar8
Copy link

@timgws Please provide latest in order to resolve this

@jeversen
Copy link

@molbi Did you find a workaround or did you fork this repo and fixed the ES5 issue ?

@timgws any news on this ?

Would really like to use this package in production too, but going further with ES 2.x doesn't seem to be acceptable.

@jeversen
Copy link

jeversen commented Jan 2, 2018

Moved my codebase to Plastic. Seems to fit my needs and can be used by the newer ES versions.

@nospoon
Copy link

nospoon commented Jan 12, 2018

Given there doesn't seem to be any interest in fixing the issue, it would seem to me the project is dead?

@ssayen
Copy link

ssayen commented Mar 11, 2018

Thanks @jeversen switched to Plastic too. Works just fine and migration from ElasticQuent is easy. Too bad, this project was really nice.

@coffeeburrito
Copy link
Contributor

coffeeburrito commented Mar 22, 2018

In case anyone is curious, the changes to support ES 5.x are actually pretty minor and there's a few forks with working code. Combined with the ability to override composer dependencies with a vcs repo, that was all I needed to get to ES5. It'll do for now, but hopefully Elasticquent gets an official update before too long.

In my own fork I bumped the elasticsearch version to 6.x and found the same code worked on upgraded 5.x indexes without any further changes, although there's probably work that would need to be done to support 6.x indexes.

@timgws
Copy link
Member

timgws commented Mar 23, 2018

Closing.

@timgws timgws closed this as completed Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests