Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mget REST API should support source parameter #4892

Closed
dadoonet opened this issue Jan 27, 2014 · 1 comment
Closed

mget REST API should support source parameter #4892

dadoonet opened this issue Jan 27, 2014 · 1 comment
Assignees
@dadoonet
Labels
>bug v0.90.11 v1.0.0.RC2 v1.1.0 v2.0.0-beta1

Comments

@dadoonet
Copy link
Member

As stated in documentation, we should support ?source= parameter in mget REST operations.

This is how to reproduce it:

curl -XDELETE "http://localhost:9200/test"

curl -XPOST "http://localhost:9200/test/type/1?refresh" -d'{
    "foo": "bar"
}'

# This one works
curl -XPOST "http://localhost:9200/test/type/_mget" -d'{
    "ids": ["1"]
}'

# This one gives: {"error":"Failed to derive xcontent from org.elasticsearch.common.bytes.BytesArray@0"}
curl -XGET "http://localhost:9200/test/type/_mget?source=%7B%22ids%22%3A%20%5B%221%22%5D%7D"
@ghost ghost assigned dadoonet Jan 27, 2014
dadoonet added a commit to dadoonet/elasticsearch that referenced this issue Jan 27, 2014
@dadoonet
mget REST API should support source parameter
1e559ac 
As stated in documentation, we should support `?source=` parameter in mget REST operations.

This is how to reproduce it:

```sh
curl -XDELETE "http://localhost:9200/test"

curl -XPOST "http://localhost:9200/test/type/1?refresh" -d'{
    "foo": "bar"
}'

# This one works
curl -XPOST "http://localhost:9200/test/type/_mget" -d'{
    "ids": ["1"]
}'

# This one gives: {"error":"Failed to derive xcontent from org.elasticsearch.common.bytes.BytesArray@0"}
curl -XGET "http://localhost:9200/test/type/_mget?source=%7B%22ids%22%3A%20%5B%221%22%5D%7D"
```

Closes elastic#4892.
@dadoonet dadoonet mentioned this issue Jan 27, 2014
Closed
dadoonet added a commit that referenced this issue Jan 27, 2014
@dadoonet
mget REST API should support source parameter
8387ecf 
As stated in documentation, we should support `?source=` parameter in mget REST operations.

This is how to reproduce it:

```sh
curl -XDELETE "http://localhost:9200/test"

curl -XPOST "http://localhost:9200/test/type/1?refresh" -d'{
    "foo": "bar"
}'

curl -XPOST "http://localhost:9200/test/type/_mget" -d'{
    "ids": ["1"]
}'

curl -XGET "http://localhost:9200/test/type/_mget?source=%7B%22ids%22%3A%20%5B%221%22%5D%7D"
```

Closes #4892.
dadoonet added a commit that referenced this issue Jan 27, 2014
@dadoonet
mget REST API should support source parameter
6e21244 
As stated in documentation, we should support `?source=` parameter in mget REST operations.

This is how to reproduce it:

```sh
curl -XDELETE "http://localhost:9200/test"

curl -XPOST "http://localhost:9200/test/type/1?refresh" -d'{
    "foo": "bar"
}'

curl -XPOST "http://localhost:9200/test/type/_mget" -d'{
    "ids": ["1"]
}'

curl -XGET "http://localhost:9200/test/type/_mget?source=%7B%22ids%22%3A%20%5B%221%22%5D%7D"
```

Closes #4892.
dadoonet added a commit that referenced this issue Jan 27, 2014
@dadoonet
mget REST API should support source parameter
61e16b3 
As stated in documentation, we should support `?source=` parameter in mget REST operations.

This is how to reproduce it:

```sh
curl -XDELETE "http://localhost:9200/test"

curl -XPOST "http://localhost:9200/test/type/1?refresh" -d'{
    "foo": "bar"
}'

curl -XPOST "http://localhost:9200/test/type/_mget" -d'{
    "ids": ["1"]
}'

curl -XGET "http://localhost:9200/test/type/_mget?source=%7B%22ids%22%3A%20%5B%221%22%5D%7D"
```

Closes #4892.
dadoonet added a commit that referenced this issue Jan 27, 2014
@dadoonet
Revert mget yaml test changes
fdbdb70 
Relative to #4892
dadoonet added a commit that referenced this issue Jan 27, 2014
@dadoonet
Revert mget yaml test changes
e3d8711 
Relative to #4892
dadoonet added a commit that referenced this issue Jan 27, 2014
@dadoonet
Revert mget yaml test changes
c737bb8 
Relative to #4892
dadoonet added a commit that referenced this issue Jan 27, 2014
@dadoonet
Revert mget yaml test changes
8863ec1 
Relative to #4892
dadoonet added a commit that referenced this issue Jan 27, 2014
@dadoonet
Revert mget yaml test changes
f76ee2b 
Relative to #4892
dadoonet added a commit that referenced this issue Jan 27, 2014
@dadoonet
Revert mget yaml test changes
c40e076 
Relative to #4892
dadoonet added a commit that referenced this issue Jan 27, 2014
@dadoonet
Revert mget yaml test changes
09575eb 
Relative to #4892
dadoonet added a commit that referenced this issue Jan 27, 2014
@dadoonet
Revert mget yaml test changes
02d5e1c 
Relative to #4892
@dadoonet dadoonet mentioned this issue Jan 28, 2014
Closed
dadoonet added a commit to dadoonet/elasticsearch that referenced this issue Jan 28, 2014
@dadoonet
Fix potential NPE when no source and no body
94f5780 
In recent changes, we added missing support for `source` parameter in some REST APIs:

* elastic#4892 : mget
* elastic#4900 : mpercolate
* elastic#4901 : msearch
* elastic#4902 : mtermvectors
* elastic#4903 : percolate

```java
        BytesReference content = null;
        if (request.hasContent()) {
            content = request.content();
        } else {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

It's definitely better to have:

```java
        BytesReference content = request.content();
        if (!request.hasContent()) {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

That said, it could be nice to have a single method to manage it for various REST actions.

Closes elastic#4924.
@dadoonet dadoonet mentioned this issue Jan 28, 2014
Closed
dadoonet added a commit that referenced this issue Jan 28, 2014
@dadoonet
Fix potential NPE when no source and no body
d621ab9 
In recent changes, we added missing support for `source` parameter in some REST APIs:

* #4892 : mget
* #4900 : mpercolate
* #4901 : msearch
* #4902 : mtermvectors
* #4903 : percolate

```java
        BytesReference content = null;
        if (request.hasContent()) {
            content = request.content();
        } else {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

It's definitely better to have:

```java
        BytesReference content = request.content();
        if (!request.hasContent()) {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

That said, it could be nice to have a single method to manage it for various REST actions.

Closes #4924.
dadoonet added a commit that referenced this issue Jan 28, 2014
@dadoonet
Fix potential NPE when no source and no body
83ba2f6 
In recent changes, we added missing support for `source` parameter in some REST APIs:

* #4892 : mget
* #4900 : mpercolate
* #4901 : msearch
* #4902 : mtermvectors
* #4903 : percolate

```java
        BytesReference content = null;
        if (request.hasContent()) {
            content = request.content();
        } else {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

It's definitely better to have:

```java
        BytesReference content = request.content();
        if (!request.hasContent()) {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

That said, it could be nice to have a single method to manage it for various REST actions.

Closes #4924.
dadoonet added a commit that referenced this issue Jan 28, 2014
@dadoonet
Fix potential NPE when no source and no body
4e1a947 
In recent changes, we added missing support for `source` parameter in some REST APIs:

* #4892 : mget
* #4900 : mpercolate
* #4901 : msearch
* #4902 : mtermvectors
* #4903 : percolate

```java
        BytesReference content = null;
        if (request.hasContent()) {
            content = request.content();
        } else {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

It's definitely better to have:

```java
        BytesReference content = request.content();
        if (!request.hasContent()) {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

That said, it could be nice to have a single method to manage it for various REST actions.

Closes #4924.
dadoonet added a commit that referenced this issue Jan 28, 2014
@dadoonet
Fix potential NPE when no source and no body
088968d 
In recent changes, we added missing support for `source` parameter in some REST APIs:

* #4892 : mget
* #4900 : mpercolate
* #4901 : msearch
* #4902 : mtermvectors
* #4903 : percolate

```java
        BytesReference content = null;
        if (request.hasContent()) {
            content = request.content();
        } else {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

It's definitely better to have:

```java
        BytesReference content = request.content();
        if (!request.hasContent()) {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

That said, it could be nice to have a single method to manage it for various REST actions.

Closes #4924.
@rb2k
Copy link

rb2k commented Oct 27, 2014

I just ran into this:

Elasticsearch::Transport::Transport::Errors::BadRequest: [400] {"error":"ElasticsearchParseException[Failed to derive xcontent from org.elasticsearch.common.bytes.BytesArray@1]","status":400}
gems/elasticsearch-transport-1.0.6/lib/elasticsearch/transport/transport/base.rb:132 __raise_transport_error
gems/elasticsearch-transport-1.0.6/lib/elasticsearch/transport/transport/base.rb:224 perform_request
gems/elasticsearch-transport-1.0.6/lib/elasticsearch/transport/transport/http/manticore.rb:33 perform_request
gems/elasticsearch-transport-1.0.6/lib/elasticsearch/transport/client.rb:111 perform_request
gems/elasticsearch-api-1.0.6/lib/elasticsearch/api/actions/mget.rb:70 mget

I tried using:

      :transport_class => Elasticsearch::Transport::Transport::HTTP::Manticore

Is this a possible regression?

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@dadoonet
mget REST API should support source parameter
ca4a95f 
As stated in documentation, we should support `?source=` parameter in mget REST operations.

This is how to reproduce it:

```sh
curl -XDELETE "http://localhost:9200/test"

curl -XPOST "http://localhost:9200/test/type/1?refresh" -d'{
    "foo": "bar"
}'

curl -XPOST "http://localhost:9200/test/type/_mget" -d'{
    "ids": ["1"]
}'

curl -XGET "http://localhost:9200/test/type/_mget?source=%7B%22ids%22%3A%20%5B%221%22%5D%7D"
```

Closes elastic#4892.
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@dadoonet
Revert mget yaml test changes
a37ffdb 
Relative to elastic#4892
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@dadoonet
Revert mget yaml test changes
e844918 
Relative to elastic#4892
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@dadoonet
Fix potential NPE when no source and no body
d3c3264 
In recent changes, we added missing support for `source` parameter in some REST APIs:

* elastic#4892 : mget
* elastic#4900 : mpercolate
* elastic#4901 : msearch
* elastic#4902 : mtermvectors
* elastic#4903 : percolate

```java
        BytesReference content = null;
        if (request.hasContent()) {
            content = request.content();
        } else {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

It's definitely better to have:

```java
        BytesReference content = request.content();
        if (!request.hasContent()) {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

That said, it could be nice to have a single method to manage it for various REST actions.

Closes elastic#4924.
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@dadoonet
mget REST API should support source parameter
9ecbbe3 
As stated in documentation, we should support `?source=` parameter in mget REST operations.

This is how to reproduce it:

```sh
curl -XDELETE "http://localhost:9200/test"

curl -XPOST "http://localhost:9200/test/type/1?refresh" -d'{
    "foo": "bar"
}'

curl -XPOST "http://localhost:9200/test/type/_mget" -d'{
    "ids": ["1"]
}'

curl -XGET "http://localhost:9200/test/type/_mget?source=%7B%22ids%22%3A%20%5B%221%22%5D%7D"
```

Closes elastic#4892.
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@dadoonet
Revert mget yaml test changes
3e10865 
Relative to elastic#4892
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@dadoonet
Revert mget yaml test changes
6572534 
Relative to elastic#4892
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@dadoonet
Fix potential NPE when no source and no body
3ff204d 
In recent changes, we added missing support for `source` parameter in some REST APIs:

* elastic#4892 : mget
* elastic#4900 : mpercolate
* elastic#4901 : msearch
* elastic#4902 : mtermvectors
* elastic#4903 : percolate

```java
        BytesReference content = null;
        if (request.hasContent()) {
            content = request.content();
        } else {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

It's definitely better to have:

```java
        BytesReference content = request.content();
        if (!request.hasContent()) {
            String source = request.param("source");
            if (source != null) {
                content = new BytesArray(source);
            }
        }
```

That said, it could be nice to have a single method to manage it for various REST actions.

Closes elastic#4924.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dadoonet dadoonet

Labels
>bug v0.90.11 v1.0.0.RC2 v1.1.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mget REST API should support source parameter dadoonet/elasticsearch
2 participants
@rb2k @dadoonet