Use parameters given by user to launch ES in Windows Script

[dadoonet]

As discussed in the mailing list : https://groups.google.com/group/elasticsearch/browse_thread/thread/86a682574b589fc7/938083b4a43b390e?hl=fr%F3%A5%81%A3b4a43b390e

Parameters given by user should work also for windows users

Hope this helps
David

[kimchy]

I think this can cause problems, no? Parameters need to be escaped or something? Also, it means that always all the parameters are added to ES_PARAMS. Check the bootsap one, we actually parse based on it.

I am not terribly against this, it might hinder us in the future, just want to double check it will work well...

[dadoonet]

I agree. So here is a new commit for it. Is that what you were looking for ?
I tested it with ES 0.17.6 and I'm now able to run ES with :

bin\elasticsearch.bat -Des.cluster.name=MyCluster

Thanks,
David.

[dadoonet]

Sorry ! Don't merge my pull request. There is a failure in it.
I will make more testing before you can merge it.

Sorry for that !

[dadoonet]

It's safe now :
Tested with

bin\elasticsearch.bat -Des.cluster.name=MyCluster
bin\elasticsearch.bat -Des.cluster.name=MyCluster -server
bin\elasticsearch.bat

[kimchy]

Pushed to master, thanks!