Throw exception if an additional field was placed inside the "query" body #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -574,6 +575,8 @@ private void parseSource(SearchContext context, BytesReference source) throws Se | |||
| element.parse(parser, context); | |||
| } else if (token == null) { | |||
| break; | |||
| } else if ((token != XContentParser.Token.START_OBJECT)) { | |||
There was a problem hiding this comment.
so in theory there can only be a single fieldname and from thereone we pass on to the actual query parser, right? so instead of else if we can just put an else in there and make sure we move the parser to the first fieldName as we expect it before we enter the loop?
There was a problem hiding this comment.
ok, I added a commit for this
There was a problem hiding this comment.
updated again - even more strict!
…body
Currently the parser accepts queries like
```
"query" : {
"any_query": {
...
},
"any_field_name":...
}
```
The "any_field_name" is silently ignored. However, this also causes the parser
not to move to the next closing bracket which in turn can lead to additional query
paremters being ignored such as "fields", "highlight",...
This was the case in issue elastic#4895
closes issue elastic#4895
|
I think we should push this - it's a good fix |
|
Pushed to master and 1.x. |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the parser accepts queries like
The "any_field_name" is silently ignored. However, this also causes the parser
not to move to the next closing bracket which in turn can lead to additional query
paremters being ignored such as "fields", "highlight",...
This was the case in issue #4895
closes issue #4895