Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TemplateQueryParser swallows additional parameters #5933

Closed
wants to merge 1 commit into from

Conversation

brwe
Copy link
Contributor

@brwe brwe commented Apr 24, 2014

Request parameters such as "size" and "fields" were ignored when
placed after the template query in the reqest.

Request parameters such as "size" and "fields" were ignored when
placed after the template query in the reqest.
@brwe brwe added bug labels Apr 24, 2014
@s1monw
Copy link
Contributor

s1monw commented Apr 24, 2014

good catch! LGTM

@brwe brwe closed this in c7bb784 Apr 25, 2014
brwe added a commit that referenced this pull request Apr 25, 2014
Request parameters such as "size" and "fields" were ignored when
placed after the template query in the reqest.

closes #5933
brwe added a commit that referenced this pull request Apr 25, 2014
Request parameters such as "size" and "fields" were ignored when
placed after the template query in the reqest.

closes #5933
@brwe brwe removed the review label Apr 25, 2014
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Request parameters such as "size" and "fields" were ignored when
placed after the template query in the reqest.

closes elastic#5933
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Search Templates labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search/Search Search-related issues that do not fall into other categories v1.1.2 v1.2.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants