-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Prevent usage of System Properties in the InternalTestCluster #6663
Conversation
public static String nodeMode() { | ||
Settings build = ImmutableSettings.builder() | ||
.put("node.local", System.getProperty("es.node.local", "true")) // default to local | ||
.put("es.node.mode", System.getProperty("es.node.local", "local")).build(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/es.node.local/es.node.mode ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think you should take out the es
prefix from the key that you use to put?
Left a few comments @s1monw ;) |
@javanna I pushed a new commit |
LGTM |
All settings should be passes as settings and the enviroment should not influence the test cluster settings. The settings we care about ie. `es.node.mode` and `es.logger.level` should be passed via settings. This allows tests to override these settings if they for instance need `network` transport to operate at all. Closes elastic#6663
LGTM |
All settings should be passes as settings and the enviroment should not influence the test cluster settings. The settings we care about ie. `es.node.mode` and `es.logger.level` should be passed via settings. This allows tests to override these settings if they for instance need `network` transport to operate at all. Closes #6663
just in time @spinscale |
All settings should be passes as settings and the enviroment should not
influence the test cluster settings. The settings we care about ie.
es.node.mode
andes.logger.level
should be passed via settings.This allows tests to override these settings if they for instance need
network
transport to operate at all.