Cut over to Path API for file deletion #8366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return true; | ||
| } catch (Exception e) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Seems weird to me to catch any Exception given that the method signature throws IOException?
There was a problem hiding this comment.
I agree will throw the exception
| try { | ||
| IOUtils.rm(FileSystemUtils.toPaths(nodeDatas)); | ||
| } catch (Exception ex) { | ||
| logger.debug("failed to remove node data locations", ex); |
|
LGTM |
|
pushed another review round |
Today we use the File API for file deletion as well as recursive directory deletions. This API returns a boolean if operations are successful while hiding the actual reason why they failed. The Path API throws and actual exception that might provide better insights and debug information. Closes elastic#8366
s1monw
force-pushed
the
ban_file_delete
branch
from
ba2f077
to
95171e2
Compare
|
I marked it as breaking since I changed some interfaces internally |
tlrx
added a commit
to tlrx/elasticsearch-cloud-aws
that referenced
this pull request
Nov 7, 2014
tlrx
added a commit
to tlrx/elasticsearch-cloud-gce
that referenced
this pull request
Nov 7, 2014
dadoonet
added a commit
to elastic/elasticsearch-cloud-azure
that referenced
this pull request
Nov 12, 2014
Due to this change: elastic/elasticsearch#8366 Closes #44.
tlrx
added a commit
to tlrx/elasticsearch-cloud-gce
that referenced
this pull request
Nov 14, 2014
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we use the File API for file deletion as well as recursive
directory deletions. This API returns a boolean if operations
are successful while hiding the actual reason why they failed.
The Path API throws and actual exception that might provide better
insights and debug information.