-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove memory
/ ram
store
#8536
Remove memory
/ ram
store
#8536
Conversation
LGTM, also nice to move a couple more methods to Paths instead of Files |
+1 on removing it, but lets give people more time to comment if possible |
+1, it's still possible to use ram disks if people absolutely need them and removing them reduces complexity |
+1 |
The RAM store is discuraged for production usage anyway and we don't test it in our randomized infrastructure. This commit removes it for `2.0`
8b4c4dd
to
0fcb466
Compare
memory
/ ram
storememory
/ ram
store
This was a great benefit for unit testing when running an embedded version of elasticsearch as one did not have to clean up data afterwards. It's a shame to see it removed when it still has purpose. I'm trying to understand the stance here since it is clear what a memory/ram store does. |
@djschny we've had issues in the past where there were bugs and inconsistencies in the ram store. If e provide it, we should also test it, otherwise we have no idea if it works correctly. Given that it is not recommended for production use, we decided to clear it out of our code base so that we can focus on the important stuff. |
Thanks @clintongormley - missed the part where it was known to be buggy. |
The RAM store is discuraged for production usage anyway and
we don't test it in our randomized infrastructure. This commit
removes it for
2.0