Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove memory/ ram store #8536

Merged
merged 1 commit into from
Nov 20, 2014
Merged

Remove memory/ ram store #8536

merged 1 commit into from
Nov 20, 2014

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Nov 18, 2014

The RAM store is discuraged for production usage anyway and
we don't test it in our randomized infrastructure. This commit
removes it for 2.0

@jpountz
Copy link
Contributor

jpountz commented Nov 18, 2014

LGTM, also nice to move a couple more methods to Paths instead of Files

@kimchy
Copy link
Member

kimchy commented Nov 19, 2014

+1 on removing it, but lets give people more time to comment if possible

@dakrone
Copy link
Member

dakrone commented Nov 19, 2014

+1, it's still possible to use ram disks if people absolutely need them and removing them reduces complexity

@clintongormley
Copy link

+1

The RAM store is discuraged for production usage anyway and
we don't test it in our randomized infrastructure. This commit
removes it for `2.0`
@s1monw s1monw merged commit 0fcb466 into elastic:master Nov 20, 2014
@s1monw s1monw removed the discuss label Nov 20, 2014
@dakrone dakrone removed the discuss label Nov 20, 2014
@s1monw s1monw deleted the remove_ram_dir branch November 20, 2014 14:25
@clintongormley clintongormley changed the title [STORE] Remove memory/ ram store Remove memory/ ram store Jun 6, 2015
@clintongormley clintongormley added the :Distributed/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. label Jun 6, 2015
@djschny
Copy link
Contributor

djschny commented Aug 10, 2015

This was a great benefit for unit testing when running an embedded version of elasticsearch as one did not have to clean up data afterwards. It's a shame to see it removed when it still has purpose. I'm trying to understand the stance here since it is clear what a memory/ram store does.

@clintongormley
Copy link

@djschny we've had issues in the past where there were bugs and inconsistencies in the ram store. If e provide it, we should also test it, otherwise we have no idea if it works correctly. Given that it is not recommended for production use, we decided to clear it out of our code base so that we can focus on the important stuff.

@djschny
Copy link
Contributor

djschny commented Aug 11, 2015

Thanks @clintongormley - missed the part where it was known to be buggy.

im-denisenko added a commit to im-denisenko/Elastica that referenced this pull request Sep 3, 2015
im-denisenko added a commit to im-denisenko/Elastica that referenced this pull request Sep 3, 2015
im-denisenko added a commit to im-denisenko/Elastica that referenced this pull request Sep 17, 2015
im-denisenko added a commit to im-denisenko/Elastica that referenced this pull request Sep 17, 2015
@clintongormley clintongormley added :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. and removed :Distributed/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. >enhancement v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants