-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot status api: make sure headers are handed over to inner nodes request #9409
Conversation
… over to inner nodes request
super(request); | ||
this.nodesIds = nodesIds; | ||
} | ||
|
||
protected NodesOperationRequest(String... nodesIds) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this constructor should be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we could remove it, but it's used by other requests that are created directly through java api, for instance nodes hot threads, nodes info etc. those don't need headers in their constructor, as the client automatically copies over the headers in the Rest action.
left one minor comment, other than that LGTM |
… over to inner nodes request Closes #9409
… over to inner nodes request Closes #9409
@@ -43,6 +43,11 @@ protected NodesOperationRequest() { | |||
|
|||
} | |||
|
|||
protected NodesOperationRequest(ActionRequest request, String... nodesIds) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that mean that all node operation requests suffer from the same issue? did you check for other potential bugs around this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of the other requests that extend this one are user facing requests, this is the only case where we extended for an internal request that actually needed the headers copied from the parent request. We are good ;)
… over to inner nodes request Closes elastic#9409
No description provided.