Engine: back port fix to a potential dead lock when failing engine during COMMIT_TRANSLOG flush #9501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current failShard method calls the close() method, which acquired a writer lock. If the thread comes from the flush COMMIT_TRANSLOG flush path, it already has a reader lock. This is detected by an assertion that tripped in one of our test runs.
This was fixed as part of #9211