Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging design #26

Closed
Veetaha opened this issue Aug 21, 2020 · 0 comments · Fixed by #30
Closed

Better logging design #26

Veetaha opened this issue Aug 21, 2020 · 0 comments · Fixed by #30

Comments

@Veetaha
Copy link
Contributor

Veetaha commented Aug 21, 2020

Current design of logging doesn't look well.
We have echo_cli and echo_err switches on devx_cmd::Cmd and our devx_pre_commit crate enables or disables them unsystematically making some heuristic assumptions that should actually be made by the users of the crate instead.

I suppose it is better to use log crate for logging so that the user of devx can pick the implementation of the logger it wants and filter the necessary logs.
The prefect logging implementation for xtask uses would be simplelog, however I don't like that it uses println!() and not eprintln!(). It might be reasonable to add a feature to select logging to stderr in this crate (Drakulix/simplelog.rs#62)

@bors bors bot closed this as completed in f6be7f3 Aug 29, 2020
@bors bors bot closed this as completed in #30 Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant