enable files/write API #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Wang <wangyi8848@gmail.com>
due to this change, hive.cluster will be isolated from typical ipfs.cluster. Signed-off-by: Yi Wang <wangyi@storswift.com>
Before we resolved all /dns*/ multiaddresses before we used them. When using HTTPs, the Go HTTP Client only sees the resolved IP address and it is unable to negotiate TLS with a cerficate because the request is not going to the hostname the certificate is signed for, but to the IP. This leverages a recent feature in go-multiaddr-net and uses directly the user-provided hostname. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
We should deprecate passing in Host/Port in the config, but in the meantime, it hardcoded /dns4/, meaning that if someone placed an ipv6 address in there things would break badly and weirdly. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
Fix ipfs-cluster-ctl with HTTPs multiaddresses
Signed-off-by: Yi Wang <wangyi@storswift.com>
Signed-off-by: Yi Wang <wangyi@storswift.com>
Signed-off-by: Yi Wang <wangyi@storswift.com>
Known bug: FilesWrite may occur writing interrupt. Signed-off-by: Yi Wang <wangyi@storswift.com>
Signed-off-by: Yi Wang <wangyi@storswift.com>
Signed-off-by: Yi Wang <wangyi@storswift.com>
Signed-off-by: Yi Wang <wangyi@storswift.com>
|
enable files/write API |
coder-lb
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve issues, enable files/write relats APIs.