Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Run search command locally #49

Closed
2 of 4 tasks
andylokandy opened this issue Apr 14, 2019 · 3 comments
Closed
2 of 4 tasks

Run search command locally #49

andylokandy opened this issue Apr 14, 2019 · 3 comments
Milestone
0.3.0

Comments

@andylokandy
Copy link
Member

andylokandy commented Apr 14, 2019 •
edited by dcao
Loading

More info in: #37

Implement a new search stategy to allow search command to run locally with support of index.

Details:

  1. Elba gathers info from index, including package group/name, latest version and the keywords of the latest version.
  2. Feed group/name and keywords to simsearch.
  3. Seach and show the top results.

Checklist:

  • Publish simsearch to crates.io
  • Add keywords field to index
  • Implement the new search command
  • Upload keywords to index on publish (website)
@andylokandy
Copy link
Member Author

simsearch is published to crates.io.

@dcao dcao added this to the 0.3.0 milestone Apr 15, 2019
dcao pushed a commit that referenced this issue Apr 16, 2019
Improve search and fix custom index deps
a2c709e 
  - Search functionality has now been improved - we no longer
    hit an API endpoint in order to search packages, and all
    indices specified in configuration are searched.

  - Custom index dependencies now follow the same syntax as is
    specified in the documentation; since this wasn't the case
    before, this is a breaking change.

See #49.
@andylokandy
Copy link
Member Author

I think we might not want to search on keyword. Because the cli is not the same as website where you can see what the keyword of each package is when you can't do it in cli.

@dcao
Copy link
Member

dcao commented Apr 17, 2019

I agree; plus it might be confusing for an end user trying to search for package and getting search results which don't correspond to the name of a package.
I'm going to consider this issue closed then.

@dcao dcao closed this as completed Apr 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@dcao @andylokandy