Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this a typo? #2

Closed
elect000 opened this issue Aug 25, 2018 · 1 comment
Closed

Is this a typo? #2

elect000 opened this issue Aug 25, 2018 · 1 comment

Comments

@elect000
Copy link

at attn2d/nmt/models/pooling.py
line 145.

class PositionalPooling(nn.Module):
    def __init__(self, max_length, emb_size):
        super(PositionalPooling4, self).__init__()
        self.src_embedding = nn.Embedding(max_length, emb_size)
        self.trg_embedding = nn.Embedding(max_length, emb_size)
        self.src_embedding.weight.data.fill_(1)
        self.trg_embedding.weight.data.fill_(1)
        self.src_embedding.bias.data.fill_(0)
        self.trg_embedding.bias.data.fill_(0)

Is PositionalPooling4 PositionalPooling?

@elbayadm
Copy link
Owner

It's an experimental function that I forgot to remove.

elbayadm pushed a commit that referenced this issue Jun 29, 2020
…ain_step (#2)

Summary:
Pull Request resolved: fairinternal/fairspeq#2

Pull Request resolved: facebookresearch/fairseq#689

We found not raising OOM during trainer.train_step causes various
issue, including NCCL hangs / gloo sync errors because gradient is not synced
properly. Before we found the root cause, let's give users an option to raise
OOMs.

Reviewed By: jmp84

Differential Revision: D15170357

fbshipit-source-id: 3e15e4e111a8380612157955509c39821a216ec4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants